New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation failure on MacOS 10.13 #31

Open

StanleySweet opened this issue Dec 6, 2020 · 1 comment

Contributor

StanleySweet commented Dec 6, 2020 •

edited

Loading

It seems macOS doesn't define filesystem prior to macOS 10.15

builderr-debug-macos.txt
../../../source/third_party/tinygettext/src/unix_file_system.cpp:24:10: fatal error: 'filesystem' file not found
#include <filesystem>
         ^~~~~~~~~~~~
1 error generated.
make[1]: *** [obj/tinygettext_Debug/unix_file_system.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [tinygettext] Error 2

According to https://stackoverflow.com/questions/42633477/macos-clang-c17-filesystem-header-not-found we need to include <experimental/filesystem> for those OSes

so maybe a check like

// Untested
#if defined(__APPLE__) && defined(__clang_major__) && __clang_major__ < 11
#include <experimental/filesystem>
#else
#include <filesystem>
#endif

Not sure what your requirements are for this library but I understand that os might be too old, feel free to close this issue then.

The text was updated successfully, but these errors were encountered:

Contributor Author

StanleySweet commented Dec 7, 2020

Seems like 10.13 and XCode 10.1 don't even support this.

na-Itms pushed a commit to 0ad/0ad that referenced this issue


          Update tinygettext to match upstream.

462b81b

We're now ISO on the plural forms (tinygettext/tinygettext#30), so remove the modified warning. 
We use boost filesystem as <filesystem> and <experimental/filesystem> are not available on the macOS CI yet. (tinygettext/tinygettext#31)

Differential Revision: https://code.wildfiregames.com/D3185

git-svn-id: https://svn.wildfiregames.com/public/ps/trunk@24342 3db68df2-c116-0410-a063-a993310a9797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment