fix: add missing UnknownNetworkError #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also found the Unknown error in https://github.com/tinygo-org/net/blob/94998db67997d794f3fdc7b1ef5ad600c8f83f6b/net.go This is in the open PR - #24. Regardless - getting one of these through would be ideal so tinygo can update the net submodule. |
|
Looks OK to me, thanks for the addition @elewis787 now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The net package recently added support for a custom transport to be added, largely to support the changes in tinygo for wasip2.
This PR adds the missing error type UnknownNetworkError that was introduced in #25
After adding this and updating the submodule reference in tinygo for the net package - custom HTTP transports can be successfully called when targeting wasip2.
Referenced in #31