Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy package for runtime/metrics #3709

Merged
merged 1 commit into from
May 6, 2023
Merged

Add dummy package for runtime/metrics #3709

merged 1 commit into from
May 6, 2023

Conversation

DazWilkin
Copy link
Contributor

Add dummy package for runtime/metrics so that modules that depend upon it (e.g. Prometheus Go client library) will compile.

Avoids:

package runtime/metrics is not in GOROOT

Fixes #3705

…pon it (e.g. [Prometheus Go client library](https://github.com/prometheus/client_golang/blob/main/prometheus/internal/go_runtime_metrics.go)) will compile.

Avoids:
```console
package runtime/metrics is not in GOROOT
```

Fixes #3705
@deadprogram deadprogram changed the base branch from release to dev May 5, 2023 22:50
@deadprogram
Copy link
Member

Hello @DazWilkin thank you for the PR. I switched to the dev branch as mentioned here https://tinygo.org/docs/guides/contributing/#how-to-use-our-github-repository

@DazWilkin
Copy link
Contributor Author

@deadprogram apologies!

@aykevl aykevl merged commit 373ab34 into tinygo-org:dev May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package runtime/metrics is not in GOROOT
3 participants