nRF52: set SPI TX/RX lengths even data is empty. Fixes #3868 #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadprogram
reviewed
Aug 23, 2023
src/machine/machine_nrf52xxx.go
Outdated
| @@ -296,6 +296,8 @@ func (spi SPI) Tx(w, r []byte) error { | |||
| } | |||
| spi.Bus.RXD.MAXCNT.Set(n) | |||
| r = r[n:] | |||
| } else { | |||
There was a problem hiding this comment.
Just wondering if perhaps a better syntax for this entire section might be something like this:
nr := uint32(len(r))
if nr > 255 {
nr = 255
}
if nr != 0 {
spi.Bus.RXD.PTR.Set(uint32(uintptr(unsafe.Pointer(&r[0]))))
r = r[nr:]
}
spi.Bus.RXD.MAXCNT.Set(nr)
nw := uint32(len(w))
if nw > 255 {
nw = 255
}
if nw != 0 {
spi.Bus.TXD.PTR.Set(uint32(uintptr(unsafe.Pointer(&w[0]))))
w = w[nw:]
}
spi.Bus.TXD.MAXCNT.Set(nw)
deadprogram
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
I like the way you made this change @perttierkkila thanks!
I will squash/merge this once it passes all CI test.
|
Thank you! I was a bit shy at first to do the change properly and tried to keep changes in minimum and refactored it now as it should be. It reduces one branching when no data :) |
|
Now going to squash/merge. Thanks again @perttierkkila |
This was referenced Aug 25, 2023
aykevl
reviewed
Aug 29, 2023
deadprogram
pushed a commit
that referenced
this pull request
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.