Makefile: add lld to list of build targets for wasm-ld #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current list of targets does not build wasm-ld. wasm-ld is a symlink created in ./llvm-build/bin pointing to ./lld. Add the "lld" build target to get wasm-ld into ./llvm-build/bin. Fixes a build failure where wasm-ld is not found. Signed-off-by: Christian Stewart <christian@aperture.us>
|
CI Failure looks unrelated to changes in this PR |
You are correct. Restarted build and it passes. |
deadprogram
approved these changes
May 5, 2024
|
I wonder why this is needed? I don't see where wasm-ld is needed (unlike |
|
I'm not sure, I just got a build failure saying that tool is missing, and then after adding it to the build targets, it's fixed. So, not sure where the actual issue was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current list of targets does not build wasm-ld.
wasm-ld is a symlink created in ./llvm-build/bin pointing to ./lld.
Add the "lld" build target to get wasm-ld into ./llvm-build/bin.
Fixes a build failure where wasm-ld is not found.