Fixed issue where GetClassName would never set user defined class due… #71
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to Field always being null if Editor is not inside EditForm
Varin6
requested review from
spocke,
TheSpyder and
ltrouton
and removed request for
a team
|
Is there any action expected from me before this can be merged/approved? |
|
Thank god for this, it was giving me a nightmare. |
spocke
approved these changes
Dec 19, 2023
|
Merged this thanks for the contribution. 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to Field always being null if Editor is not inside EditForm. I believe that the condition was missing as checking for Field here only makes sense if we also check that EditContent isn't null.