-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-2347 Automation script for generating new plugin docs #3181
Conversation
…rrect alphabetical order)
…to a markdown checklist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- @FarzadHayat - please do not merge this until I get a chance to review and test please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect those template names for folders and files will not work on a windows machine. Not all of our developers are on mac/linux.
This isn't how I would solve the problem, but if the docs team is comfortable with it I won't stand in your way.
@TheSpyder good point, I had not considered windows compatibility when writing this script. While looking into this, I discovered that Do you have any suggestions for how you would approach solving this problem? |
@FarzadHayat sorry, I don't always see @ pings as I get about 100 github emails a week and tend to rely on review requests. Apparently I wasn't paying attention to the filenames when I reviewed #2801! For windows, I don't mind saying WSL is required (we do that on some of our other repositories). But that only solves the bash issue, not the filename issue. When I said Focus on the template content, which is the real concern here, not the act of using templates for which there are many options available and isn't our core competency. |
Marked as draft to stop it notifying the team until the questions are sorted out |
This ticket has been split into multiple tickets (DOC-2469 and DOC-2470) which must be completed before this ticket. |
Ticket: DOC-2347
Changes:
Pre-checks:
feature/7/
orhotfix/7/
(if applicable)
Review: