Fix undomanager typing state with modifier keys #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a keyboard shortcut is pressed, the typing state should not change.
…t keypresses involving modifier keys should not change the typing state of UndoManager.
spocke
added a commit
that referenced
this pull request
Nov 20, 2014
Fix undomanager typing state with modifier keys
|
Nice. Yes, Ctrl+A or any non typing action shouldn't enable the typing state. However it's a bit tricky to handle those cases. And I need to verify that we don't break users with non English keyboards. |
spocke
added a commit
that referenced
this pull request
Oct 19, 2017
* commit 'a7104371521630da540f1f8784e998687cd8b737': TINY-1171: fix for inserting br at beginning/end of link boundary
lnewson
added a commit
that referenced
this pull request
Feb 13, 2020
* commit 'f0bc282fa264b162960e66571365c8371cb472fd': (25 commits) Fixed tests sticky toolbar fullscreen tests failing for toolbar_location: bottom TINY-4499: Updated changelog and bumped version for 5.1.3 release Publish edits to 5.1.3 based on dev feedback editing 5.1.3 changelog windowManager.open docs updates based on dev info updating windowManager.open based on dev feedback TINY-4475: Backported docking scroll performance fix so that offset origin is lazily evaluated adding newline for domQuery.hasClass example changing example StylesSerializer to Styles docs: link windowManager.open params to options Add an example to DomQuery.hasclass API doc notification manager.open description Add a link from the init api to the docs. Publish Publish TINY-4391 Add changelog TINY-4391 Fix help dialog keyboard nav tab keyboard nav TINY-4350: Fixed the search and replace dialog appearing offscreen on iOS when scrollIntoView() is called TINY-4350: Added a temporary workaround to make the find and replace dialog work better on iOS ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there - I ran into this when writing some custom unit tests to confirm behavior of the UndoManager, and was surprised to find that e.g. the Cmd-A (or Ctrl-A) keystroke to select all flips the typing state of UndoManager to true. I'm not sure if my proposed fix here is the exact way you think it should be fixed, but the unit test I altered does seem to effectively capture the problem and is alleviated by the fix.