Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINY-8806: First pass at fixing strict mode issues #7925

Merged
merged 6 commits into from Jun 24, 2022
Merged

TINY-8806: First pass at fixing strict mode issues #7925

merged 6 commits into from Jun 24, 2022

Conversation

lnewson
Copy link
Contributor

@lnewson lnewson commented Jun 22, 2022

Related Ticket: TINY-8806

Description of Changes:

This is the first PR for the work done today to convert core to strict mode. There's still a lot more to do, but in an effort to try and keep the reviews manageable I'm going to log once per day. I should also add that while I've fixed many, I still can't add them to the tsconfig.strict.json configuration because they rely on Editor or DOMUtils.

Pre-checks:

  • Changelog entry added
  • Tests have been added (if applicable)
  • Branch prefixed with feature/, hotfix/ or spike/

Review:

  • Milestone set

GitHub issues (if applicable):

@lnewson lnewson added this to the 6.2.0 milestone Jun 22, 2022
@lnewson lnewson requested a review from a team as a code owner June 22, 2022 06:54
@lnewson lnewson requested review from spocke, TheSpyder, a team, metricjs, ltrouton and tiny-ben-tran and removed request for a team and metricjs June 22, 2022 06:54
@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2022

This pull request introduces 1 alert when merging 730faf1 into 26cedaf - view on LGTM.com

new alerts:

  • 1 for Assignment to constant

@lnewson lnewson force-pushed the feature/TINY-8806_1 branch 3 times, most recently from 3e4b307 to b839576 Compare June 22, 2022 23:24
ltrouton
ltrouton approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@ltrouton ltrouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have looked through about 2/3 of the files so far and can't see anything incorrect. Happy to give tick overall

modules/tinymce/src/core/main/ts/api/dom/Selection.ts Outdated Show resolved Hide resolved
modules/tinymce/src/core/main/ts/api/util/Tools.ts Outdated Show resolved Hide resolved
@TheSpyder TheSpyder mentioned this pull request Jun 23, 2022
Open
@lnewson lnewson merged commit 37540a9 into feature/6.2 Jun 24, 2022
@lnewson lnewson deleted the feature/TINY-8806_1 branch June 24, 2022 02:22
lnewson added a commit that referenced this pull request Jun 29, 2022
@lnewson
TINY-8806: First pass at fixing strict mode issues (#7925)
304fecd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSpyder TheSpyder TheSpyder approved these changes

@ltrouton ltrouton ltrouton approved these changes

@spocke spocke Awaiting requested review from spocke spocke was automatically assigned from tinymce/tinymce-reviewers

@tiny-ben-tran tiny-ben-tran Awaiting requested review from tiny-ben-tran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lnewson @TheSpyder @ltrouton