Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change cli library #15

Merged
merged 1 commit into from
Feb 2, 2020
Merged

change cli library #15

merged 1 commit into from
Feb 2, 2020

Conversation

ak1ra24
Copy link
Collaborator

@ak1ra24 ak1ra24 commented Jan 31, 2020

#14

@ak1ra24 ak1ra24 requested a review from slankdev January 31, 2020 08:01
@slankdev
Copy link
Contributor

very big change, I can't quick review, sorry....

@slankdev
Copy link
Contributor

slankdev commented Feb 2, 2020

In my env, Is this my mistake?

emicklei/dot is updated on 2 days ago.
https://github.com/emicklei/dot/releases/tag/v0.10.2

# git clone https://github.com/tinynetwork/tinet tinet && cd $_
# git fetch origin refs/pull/15/head
# git checkout -b ak1ra24/change-cli-library FETCH_HEAD
# go build
verifying github.com/emicklei/dot@v0.10.2: checksum mismatch
        downloaded: h1:XMI1cPtcbdNbOA2HOKFwgoph0zpqOnF28504TojB6ls=
        go.sum:     h1:vDUudhCSkKr1G3kieHqm3CiP7AsvaM25qk+46kb1i5Q=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

go.sum Show resolved Hide resolved
fix verbose option

ci: resolve golangci-lint

commands: set default value for config option
Copy link
Contributor

@slankdev slankdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. but I couldn't check all of feature. In this time, this is not necessary, and We should have additional test.

@slankdev
Copy link
Contributor

slankdev commented Feb 2, 2020

to build this.

cd /path/to/tinet
docker run --rm -it -v $PWD:/v -w /v golang:1.12 go build

Makefile can't work in my-golang-container.
also, makefile-working-fine is not necessary at this time. (but we should fix that soon)

@slankdev slankdev merged commit d1ffb10 into tinynetwork:master Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants