This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Slack vitess release patches #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Patch to handle this case while we move towards a permanent fix upstream. cf. vitessio#4661 vitessio#4669
…date-keyspace Allow empty shards when validating schemas
Track BackupEngine and BackupStorageHandle errors together.
Add support for query payload limit
ajm188
force-pushed
the
slack-vitess-release-patches
branch
from
e05bd79
to
e09912f
Compare
Not every case has `OrigErr` as non-nil, and getting at the underlying error this way can cause segfaults. It's much better to use the `Error()` function will which will safely include the error strings of any underlying errors. Signed-off-by: Andrew Mason <amason@slack-corp.com>
There are upcoming use cases where we'll create new named subcomponents of tabletserver along with the global unnamed one. Specifically for vreplication external mysql. This change will tolerate such usage and we'll just reuse the vars created by the unnamed tabletserver. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
ajm188
force-pushed
the
slack-vitess-release-patches
branch
from
eb20d9b
to
60ca994
Compare
…ype-to-logs Adds more keyspace, table and tablet_type to logs emitted to files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the following changes to our deploy branch:
sqltypes.MakeRowTrusted