This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Add option to GetSchema to only send the row count and data length over the wire #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameetkotian
reviewed
Nov 2, 2020
go/vt/vtctl/vtctl.go
Outdated
| @@ -2275,6 +2276,8 @@ func commandGetSchema(ctx context.Context, wr *wrangler.Wrangler, subFlags *flag | |||
| excludeTables := subFlags.String("exclude_tables", "", "Specifies a comma-separated list of tables to exclude. Each is either an exact match, or a regular expression of the form /regexp/") | |||
| includeViews := subFlags.Bool("include-views", false, "Includes views in the output") | |||
| tableNamesOnly := subFlags.Bool("table_names_only", false, "Only displays table names that match") | |||
| tableSizesOnly := subFlags.Bool("table_sizes_only", false, "Only displays size information for tables") | |||
There was a problem hiding this comment.
I think we need to handle the case when both tableNamesOnly and tableSizesOnly are specified. The logic should be clear about what is returned. Now, it looks like only table names are returned.
|
Corresponding upstream PR vitessio#6985 |
…er the wire (vitessio#6985) * Add option to GetSchema to only send the row count and data length over the wire Signed-off-by: Andrew Mason <amason@slack-corp.com> * Update help text to clarify behavior Signed-off-by: Andrew Mason <amason@slack-corp.com> * Add endtoend test for vtctl GetSchema Signed-off-by: Andrew Mason <amason@slack-corp.com> * Alias the proto imports Signed-off-by: Andrew Mason <amason@slack-corp.com> * Format imports to match vtctl.go Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
backport-am_get_schema_sizes_only
branch
from
215b3d5
to
0e5b756
Compare
|
@ameetkotian @setassociative this has been merged into upstream, this backports the final version |
ameetkotian
approved these changes
Dec 1, 2020
setassociative
pushed a commit
that referenced
this pull request
Mar 17, 2021
Add option to GetSchema to only send the row count and data length over the wire
setassociative
added a commit
that referenced
this pull request
Mar 17, 2021
* Merge pull request #187 from tinyspeck/backport-am_get_schema_sizes_only Add option to GetSchema to only send the row count and data length over the wire * whitespace! * derp, actually commit rm dead import Signed-off-by: Richard Bailey <rbailey@slack-corp.com> Co-authored-by: Andrew Mason <amason@slack-corp.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to GetSchema to only send the row count and data length over the wire
Signed-off-by: Andrew Mason amason@slack-corp.com