This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Vitess v8 VTctld custom branch + sizes-only #201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were merge conflicts here, would appreciate extra eyes.
Two items of note
1️⃣ the following diff no longer seemed relevant given that the grpc interface had been evolved to support sizes only as a first class flag
2️⃣ The other call out is. that the incoming change wanted to
return printJSON(wr.Logger(), resp.Schema)
as the return type which diverged from upstream's mainline so I believe this is the render bug we fixed previously.