Extracted rendering functionality into implementations of HtmlBuilder. #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sembler
commented
May 17, 2021
sembler
commented
- Two HtmlBuilders are implemented, FlatHtml and IndentedHtml. Each offers the equivalent output as ContainerTag.render() and ContainerTag.renderFormatted.
- Existing implementations of DomContent/Renderable were updated to support HtmlBuilder where possible.
- Attribute was altered to support the use of TagBuilder.
- Config was altered to allow instances to be created, which can be passed into factory methods for the HtmlBuilders. Config.defaults() can be used for library defaults, while Config.global() can be used for current static configuration.
- Retained compatibility with previous library version as much as possible. See RenderingCompatabilityTest.
- Two HtmlBuilders are implemented, FlatHtml and IndentedHtml. Each offers the equivalent output as ContainerTag.render() and ContainerTag.renderFormatted. - Existing implementations of DomContent/Renderable were updated to support HtmlBuilder where possible. - Attribute was altered to support the use of TagBuilder. - Config was altered to allow instances to be created, which can be passed into factory methods for the HtmlBuilders. Config.defaults() can be used for library defaults, while Config.global() can be used for current static configuration. - Retained compatibility with previous library version as much as possible. See RenderingCompatabilityTest.
obecker
reviewed
May 18, 2021
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
Co-authored-by: Oliver Becker <ob@obqo.de>
- Removing unnecessary @param from javadoc. - Improving casting of HtmlBuilders in implementations of DomContent (tags, text, etc.).
- Including new tests.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.