Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play with a boxed type for ExitDisplay #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tismith
Copy link
Owner

@tismith tismith commented Aug 2, 2018

This would be a breaking change, maybe it'd be better as a different type.

@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #24   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          62     62           
=====================================
  Hits           62     62
Impacted Files Coverage Δ
src/lib.rs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22eb199...deafec7. Read the comment docs.

I wanted to use `dyn Trait` syntax in ExitDisplay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant