Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stylelint] Stylelint 15 사용, 컨픽 개선 #214

Merged
merged 4 commits into from
Mar 2, 2023
Merged

[stylelint] Stylelint 15 사용, 컨픽 개선 #214

merged 4 commits into from
Mar 2, 2023

Conversation

drakang4
Copy link
Contributor

@drakang4 drakang4 commented Feb 14, 2023 •
edited
Loading

  • stylelint 15 버전이 출시되면서 postcss-css-in-js 가 deprecated 되었고 https://www.npmjs.com/package/postcss-styled-syntax 를 사용합니다. https://stylelint.io/migration-guide/to-15
  • postcss-styled-syntax와 같이 사용하면 버그가 생기는 규칙이 있어서 일부 규칙은 끕니다.
  • stylelint-config-standard를 사용하지 않고 stylelint-config-recommended 기반으로 변경합니다. recommended는 에러 방지 규칙만 정의 되어 있는 컨픽입니다. standard 컨픽은 recommended 컨픽을 기반에 추가적으로 코드 스타일을 제한하는 규칙입니다. 원래 recommended를 사용하다가 standard로 변경한 적이 있습니다. stylelint 14 업데이트 및 stylelint-config 변경 #158
    그런데 standard 컨픽은 CSS 최신 문법을 강제하는 스타일이라서 브라우저 호환성이 부족한 문제가 있습니다. 그래서 recommended로 돌아가고 standard에서 호환성에 영향은 없지만 간결하고 규칙적인 코드 작성에 유용했던 일부 규칙만 가져오도록 변경했습니다.

@drakang4 drakang4 changed the base branch from main to monorepo February 14, 2023 11:03
@drakang4
Copy link
Contributor Author

release-canary

@github-actions
Copy link

v0.0.0-d2e5b18 has been published!

@drakang4
Copy link
Contributor Author

release-canary

@drakang4
Copy link
Contributor Author

release-canary

@github-actions
Copy link

v0.0.0-283c108 has been published!

@drakang4 drakang4 changed the title Stylelint styled [stylelint] styled syntax 라이브러리 변경 Feb 16, 2023
@drakang4 drakang4 marked this pull request as ready for review February 16, 2023 02:42
@drakang4 drakang4 marked this pull request as draft February 17, 2023 02:55
@drakang4 drakang4 changed the title [stylelint] styled syntax 라이브러리 변경 [stylelint] Stylelint 15 사용, 컨픽 개선 Feb 17, 2023
@drakang4 drakang4 self-assigned this Feb 17, 2023
@drakang4 drakang4 marked this pull request as ready for review February 17, 2023 04:31
@drakang4
Copy link
Contributor Author

release-canary

@github-actions
Copy link

v0.0.0-a4a1ad0 has been published!

@drakang4 drakang4 added this to the v5.0.0 milestone Feb 20, 2023
polysiya
polysiya previously approved these changes Feb 28, 2023
View reviewed changes
Base automatically changed from monorepo to main March 2, 2023 11:26
@drakang4 drakang4 merged commit 0a0c031 into main Mar 2, 2023
@drakang4 drakang4 deleted the stylelint-styled branch March 2, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polysiya polysiya polysiya left review comments

@inbeom inbeom Awaiting requested review from inbeom inbeom is a code owner

Assignees

@drakang4 drakang4

Labels
None yet
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drakang4 @polysiya