-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selenium-webdriver
4.0.0
#218
Merged
titusfortner
merged 1 commit into
titusfortner:main
from
yahonda:allow_selenium-webdriver_400
Oct 14, 2021
Merged
Allow selenium-webdriver
4.0.0
#218
titusfortner
merged 1 commit into
titusfortner:main
from
yahonda:allow_selenium-webdriver_400
Oct 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request will resolves the Rails issue rails/rails#43455 Since `selenium-webdriver` 4.0.0 has been released, webdriver 4.6 is not allowed likely due to version limitation in `webdrivers.gemspec`. * bundle install failure at Rails issue 43455 ``` $ bundle install Warning: the running version of Bundler (2.2.22) is older than the version that created the lockfile (2.2.29). We suggest you to upgrade to the version that created the lockfile by running `gem install bundler:2.2.29`. Fetching gem metadata from https://rubygems.org/......... Resolving dependencies......... Bundler could not find compatible versions for gem "selenium-webdriver": In Gemfile: selenium-webdriver (>= 4.0.0.alpha7) webdrivers was resolved to 4.6.0, which depends on selenium-webdriver (>= 3.0, < 4.0) Could not find gem 'selenium-webdriver (>= 3.0, < 4.0)', which is required by gem 'webdrivers', in source at `/home/yahonda/src/github.com/SeleniumHQ/selenium`. Bundler could not find compatible versions for gem "webdrivers": In snapshot (Gemfile.lock): webdrivers (= 4.6.0) In Gemfile: webdrivers Running `bundle update` will rebuild your snapshot from scratch, using only the gems in your Gemfile, which may resolve the conflict. $ ``` Refer https://rubygems.org/gems/selenium-webdriver/versions/4.0.0
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Oct 14, 2021
This pull request forces bundler to use webdriver 4.6.1 or higher to workaround rails#43455 until titusfortner/webdrivers#218 is merged and released. Fix rails#43455 titusfortner/webdrivers#218
Here is the minimum case to reproduce.
source "https://rubygems.org"
gem "webdrivers", "=4.6.1"
gem "selenium-webdriver", "=4.0.0" $ ruby -v
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux]
$ bundle
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...
Bundler could not find compatible versions for gem "selenium-webdriver":
In Gemfile:
selenium-webdriver (= 4.0.0)
webdrivers (= 4.6.1) was resolved to 4.6.1, which depends on
selenium-webdriver (>= 3.0, < 4.0)
$ |
Yes, thanks for the contribution, few other problems that needed fixing. I'll get a release out shortly. |
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Oct 14, 2021
….0.0 `webdrivers` 4.7.0 has been released including titusfortner/webdrivers#218 which supports selenium-webdriver 4.0.0 Refer https://github.com/titusfortner/webdrivers/blob/main/CHANGELOG.md#470-2021-10-14 Related to rails#43456
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves the Rails issue rails/rails#43455
Since
selenium-webdriver
4.0.0 has been released, webdriver 4.6 is not allowedlikely due to version limitation in
webdrivers.gemspec
.Refer
https://rubygems.org/gems/selenium-webdriver/versions/4.0.0