Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: svelte processor arg & improved test coverage #558

Merged
merged 3 commits into from Jan 29, 2019

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jan 29, 2019

Description

The svelte preprocessor can now take a processor arg. Also the test coverage around file invalidation for <style> is improved!

Motivation and Context

I like good tests & 100% coverage makes me feel warm and fuzzy even if it's mostly worthless.

How Has This Been Tested?

I wrote tests for it! They even pass!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

tivac added some commits Jan 29, 2019

feat: svelte takes an existing processor
No real need for this atm, but it's easy to add & support using destructuring so might as well!
docs: new svelte arg
Also removed old `clean` arg that was disabled by default and not really supported. Invalidates by default now but that only removes files **if** a new version is written over the top of them, so it should be an overall win!

@tivac tivac self-assigned this Jan 29, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 29, 2019

Codecov Report

Merging #558 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage   98.94%   99.04%   +0.09%     
==========================================
  Files          46       46              
  Lines        1045     1045              
  Branches      162      163       +1     
==========================================
+ Hits         1034     1035       +1     
+ Misses         11       10       -1
Impacted Files Coverage Δ
packages/svelte/svelte.js 100% <100%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059fd7a...9ae5067. Read the comment docs.

@tivac tivac merged commit 7655d72 into master Jan 29, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed 1 new file uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/patch 100% of diff hit (target 98.94%)
Details
codecov/project 99.04% (+0.09%) compared to 059fd7a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@tivac tivac deleted the svelte-coverage branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.