Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose component for <base> tag #105

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

gjacobrobertson
Copy link
Contributor

I'm in a similar situation as @maparent in #102. Managing a <base> tag would be useful when when situating an app within a dynamic path. I also considered exposing the HeadTag component directly, but according to MDN, the only head tags not currently supported are <base>, <script>, <noscript>, and <template>, and if you're trying to use react to manage <script>, <noscript> , or <template> tags, you've probably got bigger issues.

So here's a PR that exposes <base> tags as a <Base> component, complete with documentation, example, and typings.

@tizmagik
Copy link
Owner

Thanks @gjacobrobertson this looks great! I'm not sure why travis didn't run, I'll look into that as soon as I get a chance. Sorry for the lag time and thank you for your patience and contribution!

@tizmagik tizmagik merged commit 410ded0 into tizmagik:master Oct 9, 2020
@tizmagik
Copy link
Owner

tizmagik commented Oct 9, 2020

Released in v3.4.0

@tizmagik tizmagik mentioned this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants