Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vp8_decoder: the flush handler should not discard the codec config, only the stored stream data #354

Closed
juanrubio opened this issue Jul 17, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@juanrubio
Copy link
Member

@juanrubio juanrubio commented Jul 17, 2017

The flush handler should not do a full reset of the stream parameters. It should only discard any stream data found in the internal buffers, but keep the stream parameter information:

static OMX_ERRORTYPE
vp8d_prc_port_flush (const void * ap_obj, OMX_U32 a_pid)
{
  vp8d_prc_t * p_prc = (vp8d_prc_t *) ap_obj;
  if (OMX_ALL == a_pid || ARATELIA_VP8_DECODER_INPUT_PORT_INDEX == a_pid)
    {
      release_input_header (p_prc);
      reset_stream_parameters (p_prc);
    }
  if (OMX_ALL == a_pid || ARATELIA_VP8_DECODER_OUTPUT_PORT_INDEX == a_pid)
    {
      release_output_header (p_prc);
    }
  return OMX_ErrorNone;
}
@juanrubio juanrubio added the bug label Jul 17, 2017
@juanrubio juanrubio added this to the v0.9.0 milestone Jul 17, 2017
@juanrubio juanrubio self-assigned this Jul 17, 2017
@juanrubio juanrubio changed the title vp8_decoder: the port flush handler should not discard the codec config learned vp8_decoder: the flush handler should not discard the codec config, only the stored stream data Jul 17, 2017
@juanrubio
Copy link
Member Author

@juanrubio juanrubio commented Jul 17, 2017

Committed a potential fix here 9de14f3.

I could not find any libvpx API to flush the decoder context, so this fix might be all that needs to be done.

@CapOM, could you please re-check your test case with this fix in? Thanks!

@juanrubio
Copy link
Member Author

@juanrubio juanrubio commented Jul 18, 2017

I believe this is working now. So I'm closing this issue.

@juanrubio juanrubio closed this Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant