Handle empty message part better.

[gjohnson]

See inline comment(s).

[gjohnson]

If non-binary data is used the original implementation bombed out because that would be undefined (assuming strings, etc).

[tj]

hmm tests fail for me:

/Users/tj/projects/axon/node_modules/should/lib/should.js:125
      throw new AssertionError({
            ^
AssertionError: expected '\u0000' to have a property 'cmd'

[gjohnson]

Hmmmmm crazy, mine pass every time lol Did the test get merged and not the fix? Cause that sounds like the error that would happen in that scenario.

[tj]

looks like it got in fine haha, weird I'll check it out after work

[gjohnson]

I am still so confused on this... Do you get the error even when your seclude the test via TESTS=./test/test.whatever?

[tj]

yup if I run it directly I get that as well

[gjohnson]

crazy... just checked out directly from your master into tmp and all tests still pass over here... when you get a chance can you log out what the multipart buffer looks like:

RepSocket.prototype.onmessage = function(sock){
  var self = this;
  return function (msg, multipart){
    if (!multipart) return debug('rep expects multipart');
    var envelopes = [];

    console.log('raw msg:', msg);

    for (var i = 0; i < msg.length; ++i) {
      if ('\u0000' === String(msg[i])) {
        envelopes = msg.splice(0, ++i);
      }
    }

    console.log('app msg:', msg);

    self.emit.apply(self, ['message'].concat(msg, reply));

    function reply(){
      var args = [].slice.call(arguments);
      sock.write(self.pack(envelopes.concat(args)));
    }
  };
};

I correctly get:

raw msg: [ '\u0000', { cmd: 'hello' } ]
app msg: [ { cmd: 'hello' } ]

[tj]

wtf weird it works fine now, maybe it was on my retina, or maybe im just crazy hahaha

[gjohnson]

haha yay! I will get some other people to run it tomorrow, though I am using it constantly on a staging app and have had no probs yet... so maybe your just crazy... sorry! :-)

[tj]

must be! hahaha, I was probably running an older SHA or something, no clue