Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add generators and delegated generators benchmarks #43

Merged
merged 1 commit into from
Nov 10, 2013
Merged

add generators and delegated generators benchmarks #43

merged 1 commit into from
Nov 10, 2013

Conversation

jonathanong
Copy link
Contributor

just found out there's yield* generator which is supposed to be faster - and it is! so i added a benchmark:

screen shot 2013-11-09 at 2 26 03 pm

now the problem is that if i set the mintime too high, i'll get the following error:

screen shot 2013-11-09 at 2 28 10 pm

thus, i just made it an environmental variable and set it to 1 millisecond by default. i'm not sure why that happens.

@tj
Copy link
Owner

tj commented Nov 10, 2013

hmmm that's not good if we're exhausting stack haha

tj added a commit that referenced this pull request Nov 10, 2013
add generators and delegated generators benchmarks
@tj tj merged commit d4a5b99 into tj:master Nov 10, 2013
@jonathanong jonathanong deleted the bench-generators branch November 10, 2013 19:39
@tj
Copy link
Owner

tj commented Nov 12, 2013

@jonathanong we should add tests for non-thunkable object values as well so stuff like this is ok:

var user = yield {
  name: 'tobi',
  address: get('address')
}

@tj
Copy link
Owner

tj commented Nov 12, 2013

maybe it's fine without that, might confuse some people either way

@jonathanong
Copy link
Contributor Author

Did you want to support that? I think it's a valid use case, but I feel like most future issues will be people trying to do crazy stuff with it. I say add it but don't document it.

@tj
Copy link
Owner

tj commented Nov 12, 2013

yeah agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants