-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promote yield* next
instead of yield next
#2
Comments
i think the best thing about |
that's not even remotely enough of a gain to worry about IMO, add one console.log() per request and you take a bigger hit. If anything we could improve co's perf by adding a shared scheduler but not a huge deal really. I don't like the context switching between yield and delegation |
i'm not worrying about it :P it's just free to me. |
it would kinda almost be nicer if javascript would just auto-delegate when you yield a generator, maybe make |
i wish there were no stars anywhere |
that too |
"i wish there were no stars anywhere" That really describes the sentiment. :) |
* According to koajs/compose#2, show performances improve a lot.
+1 |
there really isn't any downside, but it's probably not worth the cognitive overhead for new beginners, especially with |
it's faster: tj/co#43
at least it'll work with or without it. it's an easy win. testing koa's benchmark, here's loa without
yield*
:with
yield*
:only problem is that
next()
should always return a generator. that's an easy fix.The text was updated successfully, but these errors were encountered: