Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .strictOptionalOptionArguments() for POSIX-style handling of options with optional option-arguments #1951

Closed
wants to merge 6 commits into from
Closed

Add .strictOptionalOptionArguments() for POSIX-style handling of options with optional option-arguments #1951

wants to merge 6 commits into from

Conversation

aweebit
Copy link
Contributor

@aweebit aweebit commented Aug 8, 2023

Fixes #1901.

ChangeLog

Added

  • .strictOptionalOptionArguments() for POSIX-style handling of options with optional option-arguments

@aweebit
Refactor parseOptions()
d7e2399 
Eliminates redundant calls and checks.

(cherry picked from commit dd2c9c8)
@aweebit
Add strictOptionalOptionArguments
1517423
@aweebit
Prevent unusable options
733d9cd 
- Check if new option is usable with current settings before registering
- Check if registered options remain usable when updating settings

_registerOption() has been borrowed from deb3bdf in tj#1923.
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 8, 2023
View reviewed changes
lib/option.js Fixed Show fixed Hide fixed
@shadowspawn
Copy link
Collaborator

This is something I have been thinking about for years. I will be interested to see how you have approached it, but may choose to do it myself.

@shadowspawn shadowspawn added the on hold Not a current focus due to dependencies on other PR or number of other PR label Aug 8, 2023
@aweebit aweebit force-pushed the feature/strictOptionalOptionArguments branch from baaae81 to 7577e65 Compare August 8, 2023 15:59
@aweebit
Copy link
Contributor Author

aweebit commented Aug 8, 2023

(Force pushed to undo the merge with #1950.)

This was referenced Aug 12, 2023
Closed
Closed
@shadowspawn shadowspawn mentioned this pull request Aug 26, 2023
Closed
@shadowspawn
Copy link
Collaborator

Leaving #1901 open to see if there is any interest or compelling use cases.

There are some extra commits in this PR, the relevant commits to the strict optionals are:

See also a different approach in #1984 where the help shows the flags as supplied by author and up to author to format appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on hold Not a current focus due to dependencies on other PR or number of other PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aweebit @shadowspawn