follow links #869
Closed
follow links #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abetomo
requested review from
abetomo and
roman-vanesyan
and removed request for
abetomo
abetomo
approved these changes
Jan 22, 2019
index.js
Outdated
| @@ -8,6 +8,7 @@ var path = require('path'); | |||
| var dirname = path.dirname; | |||
| var basename = path.basename; | |||
| var fs = require('fs'); | |||
| var readlink = require('readlink'); | |||
There was a problem hiding this comment.
Can you please inline the synchronous part of the readlink module; as module itself introduces an async module which is unnecessary for the commander and only introduce a ton of unused kb.
There was a problem hiding this comment.
I don't think that CTRL+C/CTRL+V code from readlink is good idea, because we must also provide tests and support this legacy code. If you don't like async module maybe better send PR to readlink repo to remove it from dependencies.
roman-vanesyan
requested changes
Jan 28, 2019
|
Whether to introduce dependencies is a tricky question. I'm still thinking about the tradeoffs so won't offer an opinion at this time, just add some size info. |
|
fixed in #935 |
|
Thanks @KillWolfVlad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn ~v1.10.x changed bin linking for global packages (I can't find commit with that changes).
How yarn link bin after
$ yarn global add package?But
commander.jsread link only once time. And sub-commands not work, because in directory~/.config/yarn/global/node_modules/.binother files doesn't exists.My solution: follow links and get real file name.
In GNU/Linux shell command
readlink -fimplements it:For Node.js I found package readlink with almost similar behavior (from description).
Close #866