fix: resolve symbolic links completely when hunting for subcommands

[MarshallOfSound]

Depending on your npm / yarn set up a global install may have to resolve through several symlinks before it correctly arrives the the baseDir that actually contains the other subcommands. The links go between directories so if we stop after the first link baseDir is looking in the wrong place

The changes the resolution logic to resolve symlinks until their are no more to resolve by using realpath which will resolve links all the way to the final destination.

[shadowspawn]

Might take me a few days, but I am looking forward to reviewing this. Hopefully fixes #866 (and without adding a dependency as in #869).

@MarshallOfSound could you please suggest some reproduction steps that match how a user might end up with the broken symlink? It sounded like you had something in mind:

Depending on your npm / yarn set up a global install may have to resolve through several symlinks before it correctly arrives the the baseDir that actually contains the other subcommands.

I did find mention of yarn install in #866 (comment) and will be trying that too.

[MattCheely]

@MarshallOfSound could you please suggest some reproduction steps that match how a user might end up with the broken symlink? It sounded like you had something in mind:

I'm not the OP, but I have a package that you can replicate the issue with via:

yarn global add elm-app-gen

and then run:

elm-app-gen quickstart test-app

in some temporary directory.

[MarshallOfSound]

@shadowspawn Anyone using subcommands and the latest version of yarn will have this issue afaik.

Yarn installs the binary to /usr/local/bin/my-cmd which symlinks to $YARN_DIR/.bin/my-cmd which then symlinks to $YARN_DIR/node_modules/my-package/bin/my-cmd.

You can repro this quite easily with yarn global add @electron-forge/cli && electron-forge init t in some temporary directory

[KillWolfVlad]

@MarshallOfSound I did not know about fs.realpath. Your solution looks better and more native.

[shadowspawn]

(My review progress: examined code and related issues and tested on Mac, looking good, Windows still to go.)

[shadowspawn]

Thanks, tidy.

[MarshallOfSound]

@shadowspawn What needs to happen to get this merged and released?

[shadowspawn]

@MarshallOfSound
I joined as collaborator recently and not involved in the release process itself yet. Nothing more needed from you at the moment though.

[abetomo]

Thank you!
We will release it soon.