Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify delete-merged-branches #199

Merged
merged 1 commit into from
Nov 19, 2013

Conversation

tlvince
Copy link
Contributor

@tlvince tlvince commented Oct 24, 2013

This will delete branches merged into the current branch.

This uses -d and is therefore safer than the current script (which uses
-D). IMO, this mitigates the need to prompt.

This will delete branches merged into the current branch.

This uses `-d` and is therefore safer than the current script (which uses `-D`).
IMO, this mitigates the need to prompt.
tlvince added a commit to tlvince/git-config that referenced this pull request Nov 14, 2013
tj added a commit that referenced this pull request Nov 19, 2013
@tj tj merged commit 0faaec7 into tj:master Nov 19, 2013
@tj
Copy link
Owner

tj commented Nov 19, 2013

nice I didn't know about --merged :D thanks man

@pirxpilot
Copy link
Contributor

Funny.
Kind of hard to believe @visionmedia did not know about --merged since this is how he implement git-delete-merged-branches (see: 85c0b6d)

I managed to remove my master branch couple of times so I wrote the version that did all that prompting (see: #149) Now we are back to original implementation only it's even worse since it does not even attempt to delete remote branches. I wanted to fix #161 but it does not make sense if we are going to keep reverting to original implementation.

@tj
Copy link
Owner

tj commented Dec 5, 2013

hahaha well i definitely forgot about it, i don't mind that it doesn't remove remotes anymore, takes too long but an option for it would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants