Signed release #798
Merged
Signed release #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
requested changes
Nov 25, 2019
|
@wolviecb |
wolviecb
force-pushed
the
signed_release
branch
from
d5a337c
to
8cd30fb
Compare
|
Changes made, commits squashed, thx for the feedback :) |
spacewander
requested changes
Nov 26, 2019
bin/git-release
Outdated
| @@ -34,6 +34,17 @@ if test $# -gt 0; then | |||
| -c) need_changelog=true;; | |||
| -r) remote=$2; shift ;; | |||
| -m) msg=$2; shift ;; | |||
| -s) | |||
| test -n "$keyid" && | |||
There was a problem hiding this comment.
A little cavil: please indent the -s) block like the --semver) one below.
bin/git-release
Outdated
| sign=true | ||
| ;; | ||
| -u) | ||
| test -n "$sign" && |
wolviecb
force-pushed
the
signed_release
branch
from
8cd30fb
to
704b1b4
Compare
|
@wolviecb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for gpg signed tags for the
git-releasecommandgit release -s 1Will generate a tag
1signed by the default gpg keygit release -u key-id 1Will generate a tag
1signed bykey-id