Migrate command broken #8

Merged
merged 5 commits into from Dec 4, 2011

Conversation

Projects
None yet
2 participants
Contributor

kishorenc commented Dec 3, 2011

A small code change during merging caused migrate command to be broken. Tested everything again. Also fixed the docs.

@tj tj commented on an outdated diff Dec 3, 2011

@@ -225,8 +225,8 @@ function performMigration(direction, migrationName) {
});
var migrationPath = migrationName
- ? migrationName
- : join('migrations', migrationName);
+ ? join('migrations/', migrationName)
@tj

tj Dec 3, 2011

Owner

no need for the trailing /, for windows support we should use join()

Contributor

kishorenc commented Dec 3, 2011

Removed the trailing slash.

Owner

tj commented Dec 3, 2011

crap, your changes must be conflicting with mine, can you rebase?

Contributor

kishorenc commented Dec 4, 2011

Done. Rebased and pushed.

@tj tj added a commit that referenced this pull request Dec 4, 2011

@tj tj Merge pull request #8 from kishorenc/master
Migrate command broken
cb34694

@tj tj merged commit cb34694 into tj:master Dec 4, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment