Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #54 from pgherveou/patch-3
handle confirmation closed through overlay click + unbind keydown
- Loading branch information
d75189a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realised that there are scenario where the callback will be called twice
Sorry for the noise this will need one more pull request
if you click on the close button or the cancel button, callback is fired twice
so overlay should emit and overlayclose instead of close and we should catch this event as well to call the callback
This solution is ok for you ?
d75189a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overlay only has "show" and "hide" which is fine for that component, but in here yeah we can special-case if we need to