handle confirmation closed through overlay click + unbind keydown #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pgherveou
commented
Jul 11, 2012
pgherveou
commented
- emit close when user click on overlay
- unbind document keydown on remove
- unbind document keydown on remove
Closed
| @@ -248,5 +249,6 @@ Dialog.prototype.hide = function(ms){ | |||
| Dialog.prototype.remove = function(){ | |||
| this.emit('hide'); | |||
| this.el.remove(); | |||
| $(document).unbind('keydown.dialog'); | |||
There was a problem hiding this comment.
i dont remember off hand where this binding is, in overlay? if so maybe it should be moved there
tj
added a commit
that referenced
this pull request
Jul 11, 2012
handle confirmation closed through overlay click + unbind keydown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.