Quick fix for dir_path and getsize for Azure Blob #1
Conversation
Fixed the join problem in dir_path, specified prefix arguent in rmdir and fixed getsize.
|
Thanks for this PR @mzjp2. We are in a bit of a tough spot because I am in a fork chain w/ @friedrichknuth, and because this branch includes @rabernat's GCSStore, which I don't think we should include in an upstream PR. For this reason I am going to do a little clean up by rebranching from upstream master, cherry pick most of the commits from this branch, and at that point we can merge your PR, and then do an upstream PR. Sorry this is so complicated, but I think we can make it happen. |
|
Ah yes, I did notice the slightly convoluted fork chain. Glad to know we can make it happen. If I can assist with the cleanup in any way, please let me know, I'd be happy to help! |
|
@mzjp2, I did some maintenance on the fork chain and the commits to this branch. Unfortunately this required a rewrite of history on this fork and on the immediate upstream fork. I am sorry about this. However I was able to add a doc string, remove the GCSStore MutableMapping, and rebase the entire abs_store branch onto the upstream (upstream) master. So if you are okay with this, I'm guessing that the best way forward is for you to either refork, or you to clean up on your side with a fetch/rebase, and then we can add your PR. At that point I think we can do a PR all the way upstream, get this into at least a branch on the main repo, and we can get out of this fork chain difficulty. Does this sound like a good idea to you? |
|
No worries @tjcrone, I went for the easier option (as my changes were relatively minor) and just reforked. Thanks for your work on the maintenance of the fork chain 👍 |
|
Thanks @tjcrone and @mzjp2. Taking a slightly higher level view for a moment, what we really need in order to continue with out testing is a code base that combines the abbstore work AND the combined metadata work (zarr-developers#268). Given the state of the various forks, what is the best way to achieve this? |
Fixed the join problem in dir_path, specified prefix arguent in rmdir and fixed getsize.