Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update accounts documentation to clarify aspects #1039

Merged
merged 1 commit into from Sep 7, 2020
Merged

Conversation

theo-o
Copy link
Member

@theo-o theo-o commented Sep 7, 2020

Proposed changes

  • Update CSL Account Documentation to reflect changes for SY2020-21 and clarify some vocab and steps.

Brief description of rationale

Some parts of the current accounts docs are unclear.

@theo-o theo-o requested a review from a team as a code owner September 7, 2020 14:06
@coveralls
Copy link

coveralls commented Sep 7, 2020

Coverage Status

Coverage decreased (-0.007%) to 55.196% when pulling b4c28d4 on docs into 4a75e9c on dev.

@Laur04
Copy link
Member

Laur04 commented Sep 7, 2020

Should we add a note about webmail sometimes providing an Unknown error at login? It's been doing that a lot for me recently and I would rather not get a bunch of emails tomorrow about webmail showing that error. It will work if you just try again a couple of times.

@theo-o
Copy link
Member Author

theo-o commented Sep 7, 2020

Should we add a note about webmail sometimes providing an Unknown error at login? It's been doing that a lot for me recently and I would rather not get a bunch of emails tomorrow about webmail showing that error. It will work if you just try again a couple of times.

Not sure about whether account documentation is the right place to do this.

@theo-o
Copy link
Member Author

theo-o commented Sep 7, 2020

Errors with build on push can be safely ignored.

Copy link
Contributor

@etnguyen03 etnguyen03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

<li>Visit <a href="https://resetter.tjhsst.edu">https://resetter.tjhsst.edu</a> on a school or personal device.</li>
<li>Click the "Authenticate" button.</li>
<li>Click the "Authenticate" button. If you are already authenticated, you may be immediately proceed to step 4.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Click the "Authenticate" button. If you are already authenticated, you may be immediately proceed to step 4.</li>
<li>Click the "Authenticate" button. If you are already authenticated to your FCPS Google account, you may be skipped to step 4.</li>

"you may be immediately proceed" is not grammatically correct.

@Laur04
Copy link
Member

Laur04 commented Sep 7, 2020

Should we add a note about webmail sometimes providing an Unknown error at login? It's been doing that a lot for me recently and I would rather not get a bunch of emails tomorrow about webmail showing that error. It will work if you just try again a couple of times.

Not sure about whether account documentation is the right place to do this.

Probably right, maybe link to guides.tj for troubleshooting and mention it somewhere there?

@etnguyen03 etnguyen03 merged commit ad3e70f into dev Sep 7, 2020
@Laur04 Laur04 deleted the docs branch August 29, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants