-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many changes #1579
Many changes #1579
Conversation
Partially addresses tjcsl#1577
return (now < (activity_date - presign_period), activity_date - presign_period) | ||
|
||
def __str__(self): | ||
return "{} - {}".format(self.title, self.time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f-string instead of .format?
|
||
if not enrichments: | ||
has_enrichments = False | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has_enrichments = bool(enrichments)
?
intranet/apps/enrichment/views.py
Outdated
|
||
classic = False # show classic view | ||
if "classic" in request.GET: | ||
classic = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
classic = "classic" in request.GET
Other than those small changes LGTM! |
No description provided.