New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eighth updates part 2 #690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nitpick and a fix for the bug that's making the build fail. I would also squash 667e000
(refactor(eighth): eliminate redundancy
) onto d5cceb9
(refactor(eighth): refactor notification email code
).
|
||
cancelled = False | ||
|
||
if signup is None: | ||
issues += 1 | ||
|
||
if signup and signup.scheduled_activity.cancelled: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move this into an else
block with the try
/except
above.
@@ -15,7 +15,7 @@ | |||
{% else %} | |||
No activity selected | |||
{% endif %} | |||
- <a href="{{ base_url }}eighth/signup/{{ blk.block.id }}">Change Signup</a> | |||
- <a href="{{ base_url }}{{ url 'eighth_signup' blk.block.id }}">Change Signup</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- <a href="{{ base_url }}{{ url 'eighth_signup' blk.block.id }}">Change Signup</a> | |
- <a href="{{ base_url }}{% url 'eighth_signup' blk.block.id %}">Change Signup</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A few minor changes/refactors