Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): refuse to send emails in #727

Merged
merged 1 commit into from Aug 1, 2019
Merged

fix(notifications): refuse to send emails in #727

merged 1 commit into from Aug 1, 2019

Conversation

theo-o
Copy link
Member

@theo-o theo-o commented Aug 1, 2019

development. If necessary, developers can explicitly force sending the
email.

In most cases, developers only need to check that the correct email was
created which msg can do.

@theo-o
fix(notifications): refuse to send emails in
6f91633 
development. If necessary, developers can explicitly force sending the
email.

In most cases, developers only need to check that the correct email was
created which `msg` can do.
@theo-o theo-o requested a review from a user August 1, 2019 14:23
ghost
ghost approved these changes Aug 1, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good idea.

@theo-o theo-o merged commit 36302ab into dev Aug 1, 2019
@theo-o theo-o deleted the debug branch August 1, 2019 14:32
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 51.384% when pulling 6f91633 on debug into 797bebe on dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theo-o @coveralls