Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eighth fixes/tweaks #907

Merged
2 commits merged into from Nov 19, 2019
Merged

Eighth fixes/tweaks #907

2 commits merged into from Nov 19, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 19, 2019

Proposed changes

  • Fix log messages in EighthSignup.objects.create_signup() duplicate checks
  • Ignore cache more aggressively in EighthScheduledActivity.add_user()

Brief description of rationale

The log message bug was revealed in production, and the cache changes in 199c853 have failed to prevent duplicate signups.

@ghost ghost self-requested a review as a code owner November 19, 2019 01:56
@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.899% when pulling 18f40fd on anonymoose2:eighth-fixes into e53a346 on tjcsl:dev.

@ghost ghost merged commit 859b797 into tjcsl:dev Nov 19, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants