Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have signage displays send 'heartbeats' via websockets #949

Merged
2 commits merged into from Jan 26, 2020
Merged

Have signage displays send 'heartbeats' via websockets #949

2 commits merged into from Jan 26, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 26, 2020

Proposed changes

  • Have signage displays send 'heartbeats' via websockets
  • Add Prometheus metrics about which signs are online

Brief description of rationale

This will allow us to keep track of which signage displays are online more accurately.

@ghost ghost requested review from theo-o and a team as code owners January 26, 2020 19:08
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 55.271% when pulling d607fff on anonymoose2:signage into a13bfc4 on tjcsl:dev.

theo-o
theo-o approved these changes Jan 26, 2020
View reviewed changes
Copy link
Member

@theo-o theo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit dca6040 into tjcsl:dev Jan 26, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coveralls @theo-o @anonymoose2