Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate settings.SENIOR_GRADUATION_YEAR #989

Merged
merged 1 commit into from May 14, 2020
Merged

Eliminate settings.SENIOR_GRADUATION_YEAR #989

merged 1 commit into from May 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2020

Proposed changes

  • Eliminate settings.SENIOR_GRADUATION_YEAR in favor of auto-detection based on current date.

Brief description of rationale

Updating settings.SENIOR_GRADUATION_YEAR is annoying.

@ghost ghost self-requested a review as a code owner April 30, 2020 18:40
@coveralls
Copy link

coveralls commented Apr 30, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 54.736% when pulling d499eea on anonymoose2:fixes into b47f849 on tjcsl:dev.

@naitian
Copy link
Member

naitian commented Apr 30, 2020

What about the edge case where this is no graduation this year 😢

theo-o
theo-o requested changes May 2, 2020
View reviewed changes
Copy link
Member

@theo-o theo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to fixing the build (after regressions in pylint are resolved), please make the world eliminate in the commit message lower case consistent with https://github.com/tjcsl/ion/blob/master/docs/developing/howto.rst#formatting-commit-messages.

intranet/apps/context_processors.py Outdated Show resolved Hide resolved
intranet/apps/dataimport/management/commands/year_cleanup.py Outdated Show resolved Hide resolved
intranet/templates/eighth/admin/start_of_year.html Outdated Show resolved Hide resolved
intranet/utils/date.py Outdated Show resolved Hide resolved
theo-o
theo-o reviewed May 12, 2020
View reviewed changes
Copy link
Member

@theo-o theo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to incorporate recent changes to dev.

theo-o
theo-o approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@theo-o theo-o left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once build passes! Thanks for your contribution to Ion!

theo-o
theo-o requested changes May 14, 2020
View reviewed changes
Copy link
Member

@theo-o theo-o left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention that eliminate should be lowercase in the commit message.

@anonymoose2
refactor: eliminate settings.SENIOR_GRADUATION_YEAR
d499eea 
In favor of auto-detection based on current date.
@theo-o theo-o merged commit 6323a60 into tjcsl:dev May 14, 2020
@ghost ghost mentioned this pull request Aug 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coveralls @naitian @theo-o @anonymoose2