Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to commit message validation script #996

Merged
merged 2 commits into from May 14, 2020
Merged

Add check to commit message validation script #996

merged 2 commits into from May 14, 2020

Conversation

theo-o
Copy link
Member

@theo-o theo-o commented May 14, 2020

Proposed changes

  • Add a check in the commit message validation script for non-lowercase first letter in commit message
  • Adds comment explaining commit message validation script.

Brief description of rationale

Some developers forget to abide by our commit message format standards. This PR attempts to increase automation of testing of these standards.

@theo-o theo-o requested a review from a user May 14, 2020 15:07
ghost
ghost suggested changes May 14, 2020
View reviewed changes
scripts/validate-commit-messages.py Outdated Show resolved Hide resolved
scripts/validate-commit-messages.py Outdated Show resolved Hide resolved
@theo-o
style: add check in commit message validation script for
5ae04cf 
non-lowercase first letter in commit message description.

Currently, we do not validate if the first letter in the commit message
description is lowercase.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.736% when pulling 5ae04cf on fixes into 6323a60 on dev.

ghost
ghost approved these changes May 14, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "push" build is just failing because you force-pushed, so it's probably safe to merge this.

@theo-o theo-o merged commit 7b94541 into dev May 14, 2020
@theo-o
Copy link
Member Author

theo-o commented May 14, 2020 •
edited

Yes, see https://github.com/travis-ci/travis-ci/issues/2668 for buggy behavior in Travis that does not match documented behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theo-o @coveralls