Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(polls): use distinct polls in Poll.visible_to_user() #998

Merged
merged 1 commit into from
May 14, 2020
Merged

fix(polls): use distinct polls in Poll.visible_to_user() #998

merged 1 commit into from
May 14, 2020

Conversation

theo-o
Copy link
Member

@theo-o theo-o commented May 14, 2020

Proposed changes

  • Resolve bug where non-distinct polls can be returned from Poll.visible_to_user()

Brief description of rationale

Currently, non-distinct querysets can be returned from this method.

@theo-o theo-o requested a review from a team as a code owner May 14, 2020 20:32
@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.736% when pulling 7f904cd on fixes into 7b94541 on dev.

ghost
ghost approved these changes May 14, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theo-o theo-o merged commit e0031ba into dev May 14, 2020
@Laur04 Laur04 deleted the fixes branch August 29, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theo-o @coveralls