Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support of UltimakerFormatPackage #7

Open
OllisGit opened this issue Nov 15, 2019 · 1 comment
Open

[Feature] Support of UltimakerFormatPackage #7

OllisGit opened this issue Nov 15, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@OllisGit
Copy link

Hi @tjjfvi !
First: Thx, for your work!!!!

Is your feature request related to a problem? Please describe.
I was playing around with UltimakerFormatPackage-Plugin, because I want to store as much information as possible in my PrintJobHistory-Plugin. For UFP I want to store the generated Thumbnail.
And now I want to store the slicer settings, parsed by your plugin.

But unfortunately the parser only reads the file during upload and in that case the file is zipped (.ufp extension) and later extracted.

2019-11-15 17:16:14,059 - octoprint.plugin - ERROR - Error while calling plugin SlicerSettingsParser
Traceback (most recent call last):
  File "/Users/o0632/0_Projekte/3DDruck/OctoPrint/octoprint_latest/src/octoprint/plugin/__init__.py", line 219, in call_plugin
    result = getattr(plugin, method)(*args, **kwargs)
  File "/Users/o0632/0_Projekte/3DDruck/OctoPrint/octoprint_latest/venv/lib/python2.7/site-packages/octoprint_SlicerSettingsParser/__init__.py", line 52, in on_event
    self._analyze_file(payload["path"])
  File "/Users/o0632/0_Projekte/3DDruck/OctoPrint/octoprint_latest/venv/lib/python2.7/site-packages/octoprint_SlicerSettingsParser/__init__.py", line 74, in _analyze_file
    file = open(self._storage_interface.path_on_disk(path))
IOError: [Errno 2] No such file or directory: u'/Users/o0632/Library/Application Support/OctoPrint/uploads/CFFFP_TaubenWinkle.ufp

Describe the solution you'd like
Parse the settings "on file select" event instead of "upload" event.

@OllisGit OllisGit added the enhancement New feature or request label Nov 15, 2019
@tjjfvi
Copy link
Owner

tjjfvi commented Nov 20, 2019

Hi @OllisGit! Does UFP fire the FileAdded event? If so, I could add that pretty easily, without any logic for "has this file been processed already?".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants