-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudDataGrid: Add styles for resizing div #43
MudDataGrid: Add styles for resizing div #43
Conversation
@tjscience WIP of first shot for resizing. The easy part is when the grid itself is also not fixed in the width. It's still an early stage demo but I think I'm moving into the right direction 😉 |
@tjscience: In order to better support resizing when grid size is fixed, I would like to introduce a |
@TobiasBreuer, no objection there. I thought I did have column re-ordering in phase 3 and we will need something like this for it. I will add that to the phase. |
I personally like the way that DevExpress handles resizing. There are three modes, NextColumn, ColumnsContainer (what you have done so far), and Disabled. |
That's great! I actually am used to that behaviour as well (even though based on their Angular grid component - but the modes are the same there). And for this "NextColumn" feature, I like to have the deterministic order of columns based on the index parameter 😉 |
Hi @TobiasBreuer. I just wanted to check-in to see if you are still working on this. Let me know if you need anything. Thanks. |
Hey Terry,
sorry for not giving an update. It has been some busy times lately. Lot of projects with customer pressure on upcoming releases 😉
I‘ll definitely finish this feature up. The remaining effort should not be more than two days including docs and tests.
I’m planning to be finished by end of next week if this is soon enough. Otherwise please let me know then I’ll try to fasten things up by re-scheduling some other topics.
Best regards,
Tobias
|
Take your time. No rush at all. |
@tjscience: Implementation finished for both resizing variants: Please have a look and let me know what you think. |
Looks like pipeline is not happy. |
58aa2cb
to
4c7c0c2
Compare
I will take a look, thanks. |
This looks good. Thanks again! |
I have merged it and it works pretty well. Great job! I modified the example a bit to make it more consistent with how the examples work and also fixed a typo, but everything else is working well. The one thing that I think we should change here is the css to change the cursor. Right now, it only shows up when the user hovers over the resizer. However, if you are in the process of resizing and you do not go super slow, the cursor toggles back and forth between the pointer and the resize column. I think that it would be better to change the cursor for the entire data grid when we are resizing. Let me know your thoughts and if that is something that you know how to do. |
@tjscience: Good idea with the cursor improvements. I've created #55 for it. |
Feature to allow resizing of columns
Description
Allows resizing of individual columns
How Has This Been Tested?
BUnit tests and manual testing.
Example added to docs
Types of changes
Checklist:
dev
).