Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(application): rm app phase chart fetched #1763

Merged
merged 1 commit into from
Feb 10, 2022
Merged

fix(application): rm app phase chart fetched #1763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions api/application/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,6 @@ const (
type AppPhase string

const (
// ChartFetched means the chart to which the App refers
// has been fetched successfully
AppPhaseChartFetched AppPhase = "ChartFetched"
// ChartFetchedFailed means the chart to which the App
// refers could not be fetched.
AppPhaseChartFetchFailed AppPhase = "ChartFetchFailed"
Expand Down
3 changes: 0 additions & 3 deletions api/application/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,6 @@ const (
type AppPhase string

const (
// ChartFetched means the chart to which the App refers
// has been fetched successfully
AppPhaseChartFetched AppPhase = "ChartFetched"
// ChartFetchedFailed means the chart to which the App
// refers could not be fetched.
AppPhaseChartFetchFailed AppPhase = "ChartFetchFailed"
Expand Down
8 changes: 0 additions & 8 deletions pkg/application/controller/app/action/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,6 @@ func Pull(ctx context.Context,
updateStatusFunc(ctx, app, &app.Status, newStatus)
return destfile, err
}
newStatus.Phase = applicationv1.AppPhaseChartFetched
newStatus.Message = ""
newStatus.Reason = ""
newStatus.LastTransitionTime = metav1.Now()
_, err := updateStatusFunc(ctx, app, &app.Status, newStatus)
if err != nil {
return destfile, err
}
}
return destfile, err
}
2 changes: 0 additions & 2 deletions pkg/application/controller/app/app_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,6 @@ func (c *Controller) handlePhase(ctx context.Context, key string, cachedApp *cac
return c.syncAppFromRelease(ctx, cachedApp, app)
case applicationv1.AppPhaseRollbackFailed:
break
case applicationv1.AppPhaseChartFetched:
break
case applicationv1.AppPhaseChartFetchFailed:
break
case applicationv1.AppPhaseSyncFailed:
Expand Down