Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about pos_weight and norm #33

Closed
Jxu-Thu opened this issue May 9, 2019 · 2 comments
Closed

Questions about pos_weight and norm #33

Jxu-Thu opened this issue May 9, 2019 · 2 comments

Comments

@Jxu-Thu
Copy link

Jxu-Thu commented May 9, 2019

Hi @tkipf:
I have questions about 'pos_weight' in 77 line and 'norm' 78 line in https://github.com/tkipf/gae/blob/master/gae/train.py.

For unbalanced tasks, generally, we only need to rebalance the samples for training. Same as general case, you already have same number of negative samples and positive samples by negative sampling. I don't know the reason why we should put extra weight(pos_weight) to the positive samples.

So ,can you explain it?

Another question is that 'norm' seems to just scale the loss. I suppose that if we remove it the result wouldn't change.

@tkipf
Copy link
Owner

tkipf commented May 9, 2019 via email

@Jxu-Thu
Copy link
Author

Jxu-Thu commented May 9, 2019

Thanks!

@Jxu-Thu Jxu-Thu closed this as completed May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants