Skip to content

Commit

Permalink
test: Fail on router IP mismatch warnings
Browse files Browse the repository at this point in the history
We try to restore the router IP both from the filesystem (first) and
from Kubernetes objects (as a fallback). If the two IP addresses don't
match, we emit a warning.

There is no good reason for this to happen in CI so we should fail the
test if that warning ever shows up. Doing so would have prevented the
flake fixed by the previous commit.

Signed-off-by: Paul Chaignon <paul@cilium.io>
  • Loading branch information
aanm committed Nov 22, 2022
1 parent 1e947e9 commit ee4ea1a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/helpers/cons.go
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ const (
removeTransientRule = "Unable to process chain CILIUM_TRANSIENT_FORWARD with ip" // from https://github.com/cilium/cilium/issues/11276
missingIptablesWait = "Missing iptables wait arg (-w):"
localIDRestoreFail = "Could not restore all CIDR identities" // from https://github.com/cilium/cilium/pull/19556
routerIPMismatch = "Mismatch of router IPs found during restoration"

// ...and their exceptions.
opCantBeFulfilled = "Operation cannot be fulfilled on leases.coordination.k8s.io" // cf. https://github.com/cilium/cilium/issues/16402
Expand Down Expand Up @@ -295,6 +296,7 @@ var badLogMessages = map[string][]string{
removeTransientRule: nil,
missingIptablesWait: nil,
localIDRestoreFail: nil,
routerIPMismatch: nil,
"DATA RACE": nil,
// Exceptions for level=error should only be added as a last resort, if the
// error cannot be fixed in Cilium or in the test.
Expand Down

0 comments on commit ee4ea1a

Please sign in to comment.