devise を使ってユーザー認証を実装 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maedana
reviewed
Sep 4, 2021
| </p> | ||
| </header> | ||
| <% end %> | ||
| <% if request.path == '/users/sign_in' %> |
There was a problem hiding this comment.
目くじら立てるようなことじゃないのですが、特定パスに限定したのはなんでだろうなって思いました
There was a problem hiding this comment.
deviseのログイン画面でviewをアプリ側に用意せずにフラッシュメッセージを出すという目的だけのために書いたので、こういった形になりました。他の画面のフラッシュメッセージもまとめようかとも思ったのですが、booksの画面を今回はいじらないようにしました。
意図がわかりにくいので、コメントをつけるようにしてみます。
There was a problem hiding this comment.
なるほどー、そういうような理由があるんだろうなーとは思いました。OKです。ちなみに
booksの画面を今回はいじらないようにしました。
ここらへんもいじって共通化していたとしてもOK出してたと思います 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.