Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe and plan for ecosystem move to ECMAScript Modules #330

Closed
ssciolla opened this issue Feb 4, 2022 · 3 comments
Closed

Observe and plan for ecosystem move to ECMAScript Modules #330

ssciolla opened this issue Feb 4, 2022 · 3 comments
Assignees
Labels
dependencies Involves changes to NodeJS packages and versions enhancement New feature or request research
Projects

Comments

@ssciolla
Copy link
Contributor

ssciolla commented Feb 4, 2022

There is a more recent version of p-limit, version 4, but it uses ESM, which would require some tinkering with package.json and tsconfigs, and maybe more dramatic import changes across the project. This should probably be handled separately, and it may not be urgent. I need to do more reading about it. See https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c and https://www.typescriptlang.org/docs/handbook/esm-node.html

Originally posted by @ssciolla in #327 (comment)

I've done some more research on this. I will add more links below as I find them:

Resource(s):

Library standpoints:


Test Plan
Functional testing: This is full feature/regression testing

  1. Development testing
    1. Test all features
    2. test the bulk upload of Add U-M user and Bulk create sectiosn
    3. OAuthflow needs to be tested. Testing focus on token could be read, update, delete
      1. Delete the token from Canvas Profiles - > setting
      2. Let the token Refresh
      3. By 'Become user' feature
    4. Test the Database Migration. Do this by creating a new DB i.e deleting .mysql_data so DB could be created. So migrations could be applied.
      1. Use the migration commands from ReadMe
      2. Trying this from doing a local Prod build/up using docker-compose-prod.yml
@ssciolla ssciolla added dependencies Involves changes to NodeJS packages and versions enhancement New feature or request research labels Feb 4, 2022
@pushyamig
Copy link
Contributor

Should this be in icebox?

@ssciolla
Copy link
Contributor Author

ssciolla commented Feb 4, 2022

Should this be in icebox?

Yes, I don't think we should tackle this immediately, too many things still in motion it seems.

@pushyamig pushyamig added this to To Do in 2024.01.01 via automation Jan 22, 2024
@pushyamig pushyamig moved this from To Do to In Progress in 2024.01.01 Jan 23, 2024
@pushyamig pushyamig self-assigned this Feb 19, 2024
@pushyamig pushyamig moved this from In Progress to To Do in 2024.01.01 Feb 29, 2024
@pushyamig pushyamig moved this from To Do to In Progress in 2024.01.01 Mar 27, 2024
pushyamig added a commit that referenced this issue Apr 16, 2024
2024.01.01 automation moved this from In Progress to QA Apr 22, 2024
@ktowneUM
Copy link
Collaborator

Quickly tested all features
Tested the bulk upload of Add U-M user and Bulk create sections
Deleted the token from Canvas Profiles - > setting
Let the token Refresh
Used the 'act as' feature to test a teacher accessing CCM

@ktowneUM ktowneUM moved this from QA to Dev/QA in 2024.01.01 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Involves changes to NodeJS packages and versions enhancement New feature or request research
Projects
Development

No branches or pull requests

3 participants