I404 backend update #415
Merged
I404 backend update #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushyamig
commented
Feb 29, 2024
ccm_web/Dockerfile.openshift
Outdated
| @@ -1,5 +1,5 @@ | |||
| # Build stage (build client and compile server to JS) | |||
There was a problem hiding this comment.
This will be delete once we have the issue #412 merged
pushyamig
commented
Feb 29, 2024
| @@ -42,7 +42,7 @@ const getDelete = (body: string): RequestInit => { | |||
|
|
|||
| // This currently assumes all put requests have a JSON payload and receive a JSON response. | |||
| const getPut = (body: string): RequestInit => { | |||
| const headers: string[][] = [['Content-Type', jsonMimeType], ['Accept', jsonMimeType]] | |||
There was a problem hiding this comment.
I found these issues with typescript update
pushyamig
commented
Feb 29, 2024
| @@ -19,95 +19,95 @@ | |||
| "author": "", | |||
| "license": "ISC", | |||
| "dependencies": { | |||
| "@kth/canvas-api": "^4.2.2", | |||
There was a problem hiding this comment.
got and p-limit is not updated since they are ESM module and don't backport support for CJS
pushyamig
force-pushed
the
i404_backend_update
branch
2 times, most recently
from
96c606b
to
88d09ff
Compare
pushyamig
force-pushed
the
i404_backend_update
branch
from
88d09ff
to
b1b9718
Compare
|
@jaydonkrooss , I have pointed this branch to tl-its-umich-edu:2024-03-01-dep-update as we discussed. Once this merged to that branch we can have your #411 branch get the latest from this. As this has the latest typescript |
jaydonkrooss
approved these changes
Mar 4, 2024
pushyamig
merged commit efe3435
into
tl-its-umich-edu:2024-03-01-dep-update
1 check passed
pushyamig
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404
Do a NPM install and delete the node_modules for new package.json updatencupackage for checking what package are updated.gotandp-limitis not updated since they are ESM module and don't backport support for CJSTest Plan: Look for plan over here
Dep_update_test_plan: https://docs.google.com/spreadsheets/d/1kFDRcji_RySw_DtF-ZunvKhSZ9rYNMaPoVGJxVbje4c/edit#gid=0
Testing support: https://drive.google.com/drive/folders/1Ny6KgyoG-N9sOwo12gEXTOEPkB22VlUB
CCM doc: https://drive.google.com/drive/folders/1jFM54JYJVnOhUTQbZNeGQl5yW7F_uVwl