New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the git commit parsing out of the start.sh and into the build #1462
Comments
jonespm
added a commit
to jonespm/student-dashboard-django
that referenced
this issue
Dec 8, 2022
…-its-umich-edu#1462 THIS IS A draft: It was suggested to have this command to parse git in a separate file and also need to add to Dockerfile.openshift. Also this is going to need to be rebased.
3 tasks
jonespm
added a commit
to jonespm/student-dashboard-django
that referenced
this issue
Jan 12, 2023
…-its-umich-edu#1462 THIS IS A draft: It was suggested to have this command to parse git in a separate file and also need to add to Dockerfile.openshift. Also this is going to need to be rebased.
jonespm
added a commit
to jonespm/student-dashboard-django
that referenced
this issue
Jan 23, 2023
…-its-umich-edu#1462 THIS IS A draft: It was suggested to have this command to parse git in a separate file and also need to add to Dockerfile.openshift. Also this is going to need to be rebased.
Test Plan:
|
jonespm
added a commit
that referenced
this issue
Jan 26, 2023
…the build (#1463) Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
test Pass
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thank you for contributing to this project!
Describe your problem or feature you'd like added
Currently, git values are parsed in the
start.sh
script at runtime. This requiresgit
be available at runtime. Because of occasional security issues with git and libcurl it would be beneficial to just remove these packages. I believe we could just do it in the build and then remove them after.Describe the solution you'd like
Add something like this to the Dockerfile.
Remove git and read it in the start script.
Describe any possible alternatives you've considered
Some hacky solutions for pasing the .git have been considered like
But I don't really like those a lot
Additional context
It looks like you have to use a file and can't set these directly since every RUN only knows about it's own context.
https://stackoverflow.com/questions/34911622/dockerfile-set-env-to-result-of-command
The text was updated successfully, but these errors were encountered: